This repository was archived by the owner on Jan 22, 2020. It is now read-only.
404 Capability#103
Merged
samsel merged 2 commits intopaypal:v3.xfrom Oct 18, 2015
Merged
Conversation
Added Test Cases and Modified Edge Example
Contributor
|
Looks good to me, although you might want to update the README regarding the |
Contributor
Author
|
@masotime good point. Thanks! |
Contributor
There was a problem hiding this comment.
Better to call page404 as a ReactComponent than Function :)
typo - interally -> internally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Test Cases and Modified Edge Example